Thread (10 messages) 10 messages, 2 authors, 2018-07-10

[PATCH v5 4/6] bus: ti-sysc: Add support for software reset

From: Faiz Abbas <hidden>
Date: 2018-07-10 13:18:59
Also in: linux-devicetree, linux-omap, lkml

Hi Tony,

On Tuesday 10 July 2018 05:12 PM, Tony Lindgren wrote:
Hi,

* Faiz Abbas [off-list ref] [180709 16:50]:
quoted
Add support for the software reset of a target interconnect
module using its sysconfig and sysstatus registers.
...
quoted
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
...
quoted
+static int sysc_reset(struct sysc *ddata)
+{
+	int offset = ddata->offsets[SYSC_SYSCONFIG];
+	int val = sysc_read(ddata, offset);
Testing with omap4 sysc dts data I noticed we already
have modules where there is only rev register and no
SYSC_SYSCONFIG. So not using legacy mode. The
above offset with -ENODEV value will not work :)

I added some more checks and moved them to the reset
function.
Great. Thanks for the fix.

Thanks,
Faiz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help