Thread (13 messages) 13 messages, 5 authors, 2018-06-21
STALE3021d REVIEWED: 3 (3M)

1 review trailer.

[PATCH 2/3] arm64: Remove unnecessary ISBs from set_{pte, pmd, pud}

From: catalin.marinas@arm.com (Catalin Marinas)
Date: 2018-06-20 15:32:08

On Tue, Jun 19, 2018 at 01:48:14PM +0100, Will Deacon wrote:
Commit 7f0b1bf04511 ("arm64: Fix barriers used for page table modifications")
fixed a reported issue with fixmap page-table entries not being visible
to the walker due to a missing DSB instruction. At the same time, it added
ISB instructions to the arm64 set_{pte,pmd,pud} functions, which are not
required by the architecture and make little sense in isolation.

Remove the redundant ISBs.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Leif Lindholm <redacted>
Cc: Steve Capper <redacted>
Signed-off-by: Will Deacon <redacted>
Since I no longer remember the reason I added the ISBs in the first
place:

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help