Thread (9 messages) 9 messages, 4 authors, 2018-06-21
STALE2932d REVIEWED: 7 (7M)
Revisions (2)
  1. v1 [diff vs current]
  2. v1 current

[PATCH 2/2] KVM: arm64: Prevent KVM_COMPAT from being selected

From: mark.rutland@arm.com (Mark Rutland)
Date: 2018-06-19 10:10:46
Also in: kvm, kvmarm

On Tue, Jun 19, 2018 at 10:42:51AM +0100, Marc Zyngier wrote:
There is very little point in trying to support the 32bit KVM/arm API
on arm64, and this was never an anticipated use case.

Let's make it clear by not selecting KVM_COMPAT.
Do any other architectures have KVM && COMPAT, and expose an
incompatible ABI to COMPAT tasks?
Signed-off-by: Marc Zyngier <redacted>
Given the state of arm/arm64, this makes sense to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@arm.com>
quoted hunk ↗ jump to hunk
---
 virt/kvm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig
index 72143cfaf6ec..ea434ddc8499 100644
--- a/virt/kvm/Kconfig
+++ b/virt/kvm/Kconfig
@@ -47,7 +47,7 @@ config KVM_GENERIC_DIRTYLOG_READ_PROTECT
 
 config KVM_COMPAT
        def_bool y
-       depends on KVM && COMPAT && !S390
+       depends on KVM && COMPAT && !(S390 || ARM64)
 
 config HAVE_KVM_IRQ_BYPASS
        bool
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help