Hi Simon,

On Wed, Jun 13, 2018 at 4:36 PM Simon Horman [off-list ref] wrote:

On Wed, Jun 13, 2018 at 01:21:34PM +0200, Geert Uytterhoeven wrote:

quoted

On Wed, Jun 13, 2018 at 1:06 PM Simon Horman [off-list ref] wrote:

quoted

On Mon, Jun 11, 2018 at 02:15:13PM +0200, Marek Vasut wrote:

quoted

Rather than hard-coding the quirk topology, which stopped scaling,
parse the information from DT. The code looks for all compatible
PMICs -- da9063 and da9210 -- and checks if their IRQ line is tied
to the same pin. If so, the code sends a matching sequence to the
PMIC to deassert the IRQ.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon Horman <redacted>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc at vger.kernel.org
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> (on Koelsch)

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <redacted>

Note that applying it now will break gose, as its DTS doesn't describe all
regulators yet.

Ok, so old DT will break with new kernels?

For Lager, it will break with pre-v4.2 DTS, so I think that's not a problem.
For Koelsch, the regulators were added even earlier.
Stout had all regulators from the initial support in upstream.

So Gose is the only issue. Do we care?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds