On Wed, 2018-06-27 at 19:39 +0300, Andy Shevchenko wrote:

On Wed, Jun 27, 2018 at 12:21 PM,  [off-list ref] wrote:

quoted

From: Honghui Zhang <redacted>

Implement remove callback function for Mediatek PCIe driver to add
loadable kernel module support.

quoted

+static void mtk_pcie_irq_teardown(struct mtk_pcie *pcie)
+{
+       struct mtk_pcie_port *port, *tmp;
+

quoted

+       if (list_empty(&pcie->ports))
+               return;

This is redundant.

Yeah, you are right, I will remove it.

quoted

+
+       list_for_each_entry_safe(port, tmp, &pcie->ports, list) {
+               irq_set_chained_handler_and_data(port->irq, NULL, NULL);
+
+               if (port->irq_domain)
+                       irq_domain_remove(port->irq_domain);
+
+               if (IS_ENABLED(CONFIG_PCI_MSI)) {
+                       if (port->msi_domain)
+                               irq_domain_remove(port->msi_domain);
+                       if (port->inner_domain)
+                               irq_domain_remove(port->inner_domain);
+               }
+
+               irq_dispose_mapping(port->irq);
+       }
+}

quoted

+static void mtk_pcie_free_resources(struct mtk_pcie *pcie)
+{
+       struct pci_host_bridge *host = pci_host_bridge_from_priv(pcie);
+       struct list_head *windows = &host->windows;
+
+       pci_unmap_iospace(&pcie->pio);
+       pci_free_resource_list(windows);
+}
+
+static int mtk_pcie_remove(struct platform_device *pdev)
+{
+       struct mtk_pcie *pcie = platform_get_drvdata(pdev);
+       struct pci_host_bridge *host = pci_host_bridge_from_priv(pcie);
+
+       pci_stop_root_bus(host->bus);
+       pci_remove_root_bus(host->bus);
+       mtk_pcie_free_resources(pcie);
+
+       mtk_pcie_irq_teardown(pcie);
+

quoted

+       if (!list_empty(&pcie->ports))

I think this is also not needed. Do you put runtime PM by the way?

Yes, it's could be removed.
the pm was putted in mtk_pcie_put_resources which will call
mtk_pcie_subsys_powerdown, and the pm was putted in that function.

thanks.

quoted

+               mtk_pcie_put_resources(pcie);
+
+       return 0;
+}