Hi Alexandre,

On 8.06.18 ?. 18:57, Alexandre Bailon wrote:

On 03/09/2018 10:09 PM, Georgi Djakov wrote:

quoted

This patch introduce a new API to get requirements and configure the
interconnect buses across the entire chipset to fit with the current
demand.

The API is using a consumer/provider-based model, where the providers are
the interconnect buses and the consumers could be various drivers.
The consumers request interconnect resources (path) between endpoints and
set the desired constraints on this data flow path. The providers receive
requests from consumers and aggregate these requests for all master-slave
pairs on that path. Then the providers configure each participating in the
topology node according to the requested data flow path, physical links and
constraints. The topology could be complicated and multi-tiered and is SoC
specific.

Signed-off-by: Georgi Djakov <redacted>
---
 Documentation/interconnect/interconnect.rst |  96 ++++++
 drivers/Kconfig                             |   2 +
 drivers/Makefile                            |   1 +
 drivers/interconnect/Kconfig                |  10 +
 drivers/interconnect/Makefile               |   1 +
 drivers/interconnect/core.c                 | 489 ++++++++++++++++++++++++++++
 include/linux/interconnect-provider.h       | 109 +++++++
 include/linux/interconnect.h                |  40 +++
 8 files changed, 748 insertions(+)
 create mode 100644 Documentation/interconnect/interconnect.rst
 create mode 100644 drivers/interconnect/Kconfig
 create mode 100644 drivers/interconnect/Makefile
 create mode 100644 drivers/interconnect/core.c
 create mode 100644 include/linux/interconnect-provider.h
 create mode 100644 include/linux/interconnect.h

[..]

quoted

+
+/**
+ * icc_link_create() - create a link between two nodes
+ * @src_id: source node id

I guess src_id has become node and is not an id anymore,
so it should be updated.

Yes, absolutely!

quoted

+ * @dst_id: destination node id
+ *
+ * Return: 0 on success, or an error code otherwise
+ */
+int icc_link_create(struct icc_node *node, const int dst_id)
+{

Thanks,
Georgi