Thread (11 messages) read the whole thread 11 messages, 4 authors, 2018-06-11

[PATCH v6 3/6] mfd: at91-usart: added mfd driver for usart

From: alexandre.belloni@bootlin.com (Alexandre Belloni)
Date: 2018-06-11 15:36:49
Also in: linux-devicetree, linux-serial, linux-spi, lkml

On 07/06/2018 14:00:17+0300, Radu Pirea wrote:
+static int at91_usart_mode_probe(struct platform_device *pdev)
+{
+	struct mfd_cell cell;
+	u32 opmode;
This has to be initialized to AT91_USART_MODE_SERIAL...
+	int err;
+
+	err = device_property_read_u32(&pdev->dev, "atmel,usart-mode", &opmode);
+
because if the property is not present, then opmode will not be modified
which means it could hold the value of AT91_USART_MODE_SPI.


-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help