Thread (11 messages) 11 messages, 5 authors, 2018-06-03

[PATCH 1/2] clk: imx6ul: add GPIO clock gates

From: sboyd@kernel.org (Stephen Boyd)
Date: 2018-06-02 06:19:27
Also in: linux-clk, linux-devicetree, lkml

Quoting Stefan Wahren (2018-05-22 05:25:35)
quoted
+++ b/include/dt-bindings/clock/imx6ul-clock.h
@@ -242,20 +242,25 @@
 #define IMX6UL_CLK_CKO2_PODF         229
 #define IMX6UL_CLK_CKO2                      230
 #define IMX6UL_CLK_CKO                       231
+#define IMX6UL_CLK_GPIO1             232
+#define IMX6UL_CLK_GPIO2             233
+#define IMX6UL_CLK_GPIO3             234
+#define IMX6UL_CLK_GPIO4             235
+#define IMX6UL_CLK_GPIO5             236
this change looks like a breakage of devicetree ABI. You are changing the mean of the existing clock IDs on i.MX6ULL, which probably regress the combination of older DTBs with newer kernel.
Agreed. Why can't we just tack on more numbers at the end?
quoted
 
 /* For i.MX6ULL */
-#define IMX6ULL_CLK_ESAI_PRED                232
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help