[PATCH] arm64: dts: msm8916: fix Coresight ETF graph connections
From: mathieu.poirier@linaro.org (Mathieu Poirier)
Date: 2018-05-24 16:32:46
Also in:
linux-arm-msm, linux-devicetree
On 23 May 2018 at 22:48, Ivan T. Ivanov [off-list ref] wrote:
Quoting Rob Herring (2018-05-23 23:29:29)quoted
On Tue, May 8, 2018 at 10:09 AM, Rob Herring [off-list ref] wrote:quoted
The ETF input should be connected to the funnel output, and the ETF output should be connected to the replicator input. The labels are wrong and these got swapped: Warning (graph_endpoint): /soc/funnel at 821000/ports/port at 8/endpoint: graph connection to node '/soc/etf at 825000/ports/port at 1/endpoint' is not bidirectional Warning (graph_endpoint): /soc/replicator at 824000/ports/port at 2/endpoint: graph connection to node '/soc/etf at 825000/ports/port at 0/endpoint' is not bidirectional Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components") Cc: Ivan T. Ivanov <redacted> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Andy Gross <redacted> Cc: David Brown <redacted> Cc: linux-arm-msm at vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Ping. Still seeing warnings in -next for these.Hi Rob, I no longer have access to this hardware and documentation. I am sure that Mathieu and friends will take care for verification of this patch :-)
The code triggers on the "slave-mode" property rather than the labels, so this patch has no effect on how a path is established. I've tested this on a 410c and things look good. Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Regards, Ivan