Thread (4 messages) 4 messages, 2 authors, 2018-05-31

[PATCH] media: helene: fix tuning frequency of satellite

From: Katsuhiro Suzuki <hidden>
Date: 2018-05-31 08:43:11
Also in: linux-media, lkml

Hello Abylay,

I got a mistake in this patch.

DTV_FREQUENCY for satellite delivery systems, the frequency is in 'kHz' not 'Hz',
so original code is correct. Sorry for confusing...


Regards,
--
Katsuhiro Suzuki

-----Original Message-----
From: Abylay Ospan <redacted>
Sent: Wednesday, May 16, 2018 7:58 PM
To: Suzuki, Katsuhiro/?? ?? <redacted>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; linux-media
[off-list ref]; Masami Hiramatsu [off-list ref];
Jassi Brar [off-list ref]; linux-arm-kernel at lists.infradead.org;
linux-kernel at vger.kernel.org
Subject: Re: [PATCH] media: helene: fix tuning frequency of satellite

True.
I'm curious but how did it worked before ...
Which hardware (dvb adapter) are you using ?

2018-05-16 4:41 GMT-04:00 Katsuhiro Suzuki [off-list ref]:
quoted
This patch fixes tuning frequency of satellite to kHz. That as same
as terrestrial one.

Signed-off-by: Katsuhiro Suzuki <redacted>
---
 drivers/media/dvb-frontends/helene.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/helene.c
b/drivers/media/dvb-frontends/helene.c
quoted
index 04033f0c278b..0a4f312c4368 100644
--- a/drivers/media/dvb-frontends/helene.c
+++ b/drivers/media/dvb-frontends/helene.c
@@ -523,7 +523,7 @@ static int helene_set_params_s(struct dvb_frontend *fe)
        enum helene_tv_system_t tv_system;
        struct dtv_frontend_properties *p = &fe->dtv_property_cache;
        struct helene_priv *priv = fe->tuner_priv;
-       int frequencykHz = p->frequency;
+       int frequencykHz = p->frequency / 1000;
        uint32_t frequency4kHz = 0;
        u32 symbol_rate = p->symbol_rate/1000;

--
2.17.0


--
Abylay Ospan,
NetUP Inc.
http://www.netup.tv
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help