Thread (2 messages) 2 messages, 1 author, 2018-06-21
STALE2952d REVIEWED: 1 (0M)

[RESEND PATCH] media: helene: fix xtal frequency setting at power on

From: Katsuhiro Suzuki <hidden>
Date: 2018-05-29 01:09:24
Also in: linux-media, lkml
Subsystem: media drivers for helene, media input infrastructure (v4l/dvb), the rest · Maintainers: Abylay Ospan, Mauro Carvalho Chehab, Linus Torvalds

This patch fixes crystal frequency setting when power on this device.

Signed-off-by: Katsuhiro Suzuki <redacted>
Acked-by: Abylay Ospan <redacted>

---

Changes from before:
  - Add Abylay's Ack

---
 drivers/media/dvb-frontends/helene.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/helene.c b/drivers/media/dvb-frontends/helene.c
index 0a4f312c4368..8fcf7a00782a 100644
--- a/drivers/media/dvb-frontends/helene.c
+++ b/drivers/media/dvb-frontends/helene.c
@@ -924,7 +924,10 @@ static int helene_x_pon(struct helene_priv *priv)
 	helene_write_regs(priv, 0x99, cdata, sizeof(cdata));
 
 	/* 0x81 - 0x94 */
-	data[0] = 0x18; /* xtal 24 MHz */
+	if (priv->xtal == SONY_HELENE_XTAL_16000)
+		data[0] = 0x10; /* xtal 16 MHz */
+	else
+		data[0] = 0x18; /* xtal 24 MHz */
 	data[1] = (uint8_t)(0x80 | (0x04 & 0x1F)); /* 4 x 25 = 100uA */
 	data[2] = (uint8_t)(0x80 | (0x26 & 0x7F)); /* 38 x 0.25 = 9.5pF */
 	data[3] = 0x80; /* REFOUT signal output 500mVpp */
-- 
2.17.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help