[PATCH v4 4/8] PCI: Replace dev_node parameter of of_pci_get_host_bridge_resources with device
From: Vladimir Zapolskiy <hidden>
Date: 2018-05-28 10:00:31
Also in:
linux-pci, lkml
Hi Jan, Bjorn, On 05/15/2018 12:07 PM, Jan Kiszka wrote:
From: Jan Kiszka <jan.kiszka@siemens.com> Another step towards a managed version of of_pci_get_host_bridge_resources(): Feed in the underlying device, rather than just the OF node. This will allow to use managed resource allocation internally later on. CC: Jingoo Han <jingoohan1@gmail.com> CC: Joao Pinto <redacted> CC: Lorenzo Pieralisi <redacted> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
[snip]
quoted hunk ↗ jump to hunk
diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c index a6af62e0256d..61802e55a00c 100644 --- a/drivers/pci/host/pcie-altera.c +++ b/drivers/pci/host/pcie-altera.c@@ -488,11 +488,10 @@ static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie) { int err, res_valid = 0; struct device *dev = &pcie->pdev->dev; - struct device_node *np = dev->of_node; struct resource_entry *win; - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources, - NULL); + err = of_pci_get_host_bridge_resources(dev, 0, 0xff + &pcie->resources, NULL); if (err) return err;
In case if it is an undiscovered issue, a comma was mistakenly removed, which will result it compilation error. The problem is also found in pci/next , see commit 88e3909aa125. -- With best wishes, Vladimir