Thread (13 messages) 13 messages, 2 authors, 2018-05-24

[PATCH v3 4/6] watchdog: sp805: set WDOG_HW_RUNNING when appropriate

From: linux@roeck-us.net (Guenter Roeck)
Date: 2018-05-24 17:11:17
Also in: linux-devicetree, linux-watchdog, lkml

On Thu, May 24, 2018 at 09:36:25AM -0700, Ray Jui wrote:

On 5/24/2018 9:19 AM, Guenter Roeck wrote:
quoted
On Wed, May 23, 2018 at 05:15:22PM -0700, Ray Jui wrote:
quoted
If the watchdog hardware is already enabled during the boot process,
when the Linux watchdog driver loads, it should reset the watchdog and
tell the watchdog framework. As a result, ping can be generated from
the watchdog framework, until the userspace watchdog daemon takes over
control

Signed-off-by: Ray Jui <redacted>
Reviewed-by: Vladimir Olovyannikov <redacted>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>

I have one question, though: Is it really correct that both
INT_ENABLE _and_ RESET_ENABLE have to be set to enable the watdog ?
What if only RESET_ENABLE is set ?
According to the SP805 TRM, INT_ENABLE needs to be set to high to enable the
counter and the interrupt. Counter will be stopped if INT_ENABLE is cleared.
So yes, INT_ENABLE needs to be set.
Excellent, thanks for the clarification.

Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help