Thread (36 messages) 36 messages, 2 authors, 2018-06-26

[PATCH v11 01/27] clk: davinci: pll: allow dev == NULL

flat view

From: Sekhar Nori <hidden>
Date: 2018-05-22 08:45:02
Also in: linux-clk, linux-devicetree, lkml

On Friday 18 May 2018 10:18 PM, David Lechner wrote:
quoted hunk ↗ jump to hunk
@@ -711,11 +777,11 @@ int of_davinci_pll_init(struct device *dev,
 		int n_clks =  max_sysclk_id + 1;
 		int i;
 
-		clk_data = devm_kzalloc(dev, sizeof(*clk_data), GFP_KERNEL);
+		clk_data = kzalloc(sizeof(*clk_data), GFP_KERNEL);
 		if (!clk_data)
 			return -ENOMEM;
 
-		clks = devm_kmalloc_array(dev, n_clks, sizeof(*clks), GFP_KERNEL);
+		clks = kmalloc_array(n_clks, sizeof(*clks), GFP_KERNEL);
 		if (!clks)
 			return -ENOMEM;
This should be:

		if (!clks) {
			kfree(clk_data);
			return -ENOMEM;
		}

With that fixed:

Reviewed-by: Sekhar Nori <redacted>

Thanks,
Sekhar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help