[PATCH 12/33] clk: bcm2835: use match_string() helper
From: Yisheng Xie <hidden>
Date: 2018-05-22 03:43:10
Also in:
linux-clk, lkml
From: Yisheng Xie <hidden>
Date: 2018-05-22 03:43:10
Also in:
linux-clk, lkml
Hi Andy, On 2018/5/22 5:50, Andy Shevchenko wrote:
On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie [off-list ref] wrote:quoted
match_string() returns the index of an array for a matching string, which can be used intead of open coded variant. Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Eric Anholt <redacted> Cc: Stefan Wahren <redacted> Cc: linux-clk at vger.kernel.org Cc: linux-rpi-kernel at lists.infradead.org Cc: linux-arm-kernel at lists.infradead.org Signed-off-by: Yisheng Xie <redacted>quoted
- size_t i, j; - int ret; + int i, ret;I do not see any need to change type for i.
Right, I just want to smaller the line of code, for unsinged int is also OK for i. Anyway, I can change it as your suggestion in next version. Thanks Yisheng
quoted
+ ret = match_string(cprman_parent_names, + ARRAY_SIZE(cprman_parent_names), + parents[i]); + if (ret >= 0) + parents[i] = cprman->real_parent_names[ret];