On 17-05-18, 11:53, Srinivas Kandagatla wrote:

On 17/05/18 11:50, Vinod Koul wrote:

quoted

On 17-05-18, 10:59, Srinivas Kandagatla wrote:

quoted

diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
index 4a828c18099a..a05fff8a1447 100644
--- a/drivers/dma/qcom/bam_dma.c
+++ b/drivers/dma/qcom/bam_dma.c

@@ -451,7 +451,7 @@ static void bam_reset_channel(struct bam_chan *bchan)
  /**
   * bam_chan_init_hw - Initialize channel hardware
   * @bchan: bam channel
- *
+ * @dir: DMA transfer direction

Do you want to add an empty line here?

TBH, Am not 100% sure it it adds any value.

Most of the function docs in the file have this same issue.. :-)

let me know if you still want an empty line, I can respin.

Yeah that's why asked, I can edit while applying so no issues

-- 
~Vinod