[PATCH 3/9] soc: fsl: set rcpm bit for FTM
From: Yinbo Zhu <hidden>
Date: 2018-05-14 07:47:56
Also in:
linux-devicetree, linuxppc-dev, lkml
-----Original Message----- From: Leo Li Sent: 2018?5?12? 1:00 To: Yinbo Zhu <redacted>; Yinbo Zhu <redacted>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Catalin Marinas ) <catalin.marinas@arm.com>; Will Deacon ) <redacted>; Lorenzo Pieralisi ) <redacted> Cc: Xiaobo Xie <redacted>; Ran Wang <redacted>; Daniel Lezcano <redacted>; Thomas Gleixner <redacted>; Shawn Guo <shawnguo@kernel.org>; Madalin-cristian Bucur <madalin.bucur@nxp.com>; Z.q. Hou <zhiqiang.hou@nxp.com>; Jerry Huang <redacted>; M.h. Lian <minghuan.lian@nxp.com>; Qiang Zhao <qiang.zhao@nxp.com>; Fabio Estevam <redacted>; Jiaheng Fan <redacted>; Po Liu <redacted>; Nipun Gupta <redacted>; Horia Geant? <horia.geanta@nxp.com>; Priyanka Jain <redacted>; Sumit Garg <redacted>; costi <redacted>; Bogdan Purcareata <redacted>; open list:CLOCKSOURCE, CLOCKEVENT DRIVERS <redacted>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <redacted>; linux-arm-kernel at lists.infradead.org; open list:FREESCALE SOC DRIVERS <redacted>; Andy Tang <redacted>; Ying Zhang <redacted> Subject: RE: [PATCH 3/9] soc: fsl: set rcpm bit for FTM
quoted hunk ↗ jump to hunk
-----Original Message----- From: Yinbo Zhu [mailto:yinbo.zhu at nxp.com] Sent: Thursday, May 10, 2018 10:35 PM To: Yinbo Zhu <redacted>; Rob Herring <robh+dt@kernel.org>; Mark Rutland [off-list ref]; Catalin Marinas ) [off-list ref]; Will Deacon ) [off-list ref]; Lorenzo Pieralisi ) [off-list ref]; Leo Li [off-list ref] Cc: Xiaobo Xie <redacted>; Ran Wang <redacted>; Daniel Lezcano [off-list ref]; Thomas Gleixner [off-list ref]; Shawn Guo [off-list ref]; Madalin-cristian Bucur [off-list ref]; Z.q. Hou [off-list ref]; Jerry Huang [off-list ref]; M.h. Lian [off-list ref]; Qiang Zhao [off-list ref]; Fabio Estevam [off-list ref]; Jiaheng Fan [off-list ref]; Po Liu [off-list ref]; Nipun Gupta [off-list ref]; Horia Geant? [off-list ref]; Priyanka Jain [off-list ref]; Sumit Garg [off-list ref]; costi [off-list ref]; Bogdan Purcareata [off-list ref]; Meng Yi [off-list ref]; Wang Dongsheng [off-list ref]; open list:CLOCKSOURCE, CLOCKEVENT DRIVERS [off-list ref]; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS [off-list ref]; linux-arm-kernel at lists.infradead.org; open list:FREESCALE SOC DRIVERS [off-list ref]; Andy Tang [off-list ref]; Ying Zhang [off-list ref] Subject: [PATCH 3/9] soc: fsl: set rcpm bit for FTM From: Zhang Ying-22455 <redacted> Set RCPM for FTM when using FTM as wakeup source. Because the RCPM module of each platform has different big-end and little-end mode, there need to set RCPM depending on the platform. Signed-off-by: Zhang Ying-22455 <redacted> Signed-off-by: Yinbo Zhu <redacted> --- .../devicetree/bindings/timer/fsl,ftm-timer.txt | 7 ++ drivers/soc/fsl/layerscape/ftm_alarm.c | 92 ++++++++++++++++++- 2 files changed, 94 insertions(+), 5 deletions(-)diff --git a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txtb/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt index aa8c402..15ead58 100644--- a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt +++ b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt@@ -3,6 +3,13 @@ Freescale FlexTimer Module (FTM) Timer Requiredproperties: - compatible : should be "fsl,ftm-timer"
Hi Yingbo,
This is a change that breaks backward compatibility and not acceptable.
Hi leo, This patch if I keep the change as inner patch and push it to dash-linnux but I will not push it to upstream, It's okay? As far as I know, there was a other patch and file for replace the file and that the patch is already on the upstream https://patchwork.kernel.org/patch/9391293/
quoted hunk ↗ jump to hunk
+ Possible compatibles for ARM: + "fsl,ls1012a-ftm" + "fsl,ls1021a-ftm" + "fsl,ls1043a-ftm" + "fsl,ls1046a-ftm" + "fsl,ls1088a-ftm" + "fsl,ls208xa-ftm" - reg : Specifies base physical address and size of the register sets for the clock event device and clock source device. - interrupts : Should be the clock event device interrupt.diff --git a/drivers/soc/fsl/layerscape/ftm_alarm.cb/drivers/soc/fsl/layerscape/ftm_alarm.c index 6f9882f..811dcfa 100644--- a/drivers/soc/fsl/layerscape/ftm_alarm.c +++ b/drivers/soc/fsl/layerscape/ftm_alarm.c
There is no such file in the mainline kernel. So it looks like the patch set is
based on some internal git repo instead of the upstream Linux kernel. This kind of patches
shouldn't be sent to the upstream mailing list for review.
Regards,
Leo
This patch will not to upstream. Regards, Yinbo.