Hi Tomasz,

On Mon, May 07, 2018 at 06:13:27AM +0000, Tomasz Figa wrote:

On Thu, May 3, 2018 at 6:09 PM Baruch Siach [off-list ref] wrote:

quoted

On Thu, Mar 08, 2018 at 05:47:55PM +0800, Jacob Chen wrote:

quoted

+static int rkisp1_isp_sd_s_power(struct v4l2_subdev *sd, int on)
+{
+     struct rkisp1_device *isp_dev = sd_to_isp_dev(sd);
+     int ret;
+
+     v4l2_dbg(1, rkisp1_debug, &isp_dev->v4l2_dev, "s_power: %d\n",

on);

quoted

quoted

+
+     if (on) {
+             ret = pm_runtime_get_sync(isp_dev->dev);
+             if (ret < 0)
+                     return ret;
+
+             rkisp1_config_clk(isp_dev);
+     } else {
+             ret = pm_runtime_put(isp_dev->dev);

quoted

I commented this line out to make more than one STREAMON work. Otherwise, 
the second STREAMON hangs. I guess the bug is not this driver. Probably
something in drivers/soc/rockchip/pm_domains.c. Just noting that in case 
you or someone on Cc would like to investigate it further.

I tested v4.16-rc4 on the Tinkerboard.

Looks like that version doesn't include the IOMMU PM and clock handling
rework [1], which should fix a lot of runtime PM issues. FWIW, linux-next
seems to already include it.

[1] https://lkml.org/lkml/2018/3/23/44

Thanks for the reference.

It looks like the iommu driver part is in Linus' tree already. The DT part is 
in the v4.18-armsoc/dts32 branch of Heiko's tree. Am I missing anything?

Anyway, I'll take a look.

Thanks again,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -