[linux-sunxi] Re: [PATCH 02/21] arm64: dts: allwinner: a64: Add DE2 CCU
From: Maxime Ripard <hidden>
Date: 2018-05-02 11:49:54
Also in:
dri-devel, linux-clk, linux-devicetree, lkml
On Wed, May 02, 2018 at 07:34:21PM +0800, Icenowy Zheng wrote:
? 2018?5?2? GMT+08:00 ??7:32:50, Maxime Ripard [off-list ref] ??:quoted
On Mon, Apr 30, 2018 at 05:10:39PM +0530, Jagan Teki wrote:quoted
DE2 in A64 has clock control unit and behavior is same like H3/H5, so reuse the same in A64. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsib/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsiquoted
index 1b2ef28c42bd..67b80bbe5bf5 100644--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi@@ -43,9 +43,11 @@ */ #include <dt-bindings/clock/sun50i-a64-ccu.h> +#include <dt-bindings/clock/sun8i-de2.h> #include <dt-bindings/clock/sun8i-r-ccu.h> #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/reset/sun50i-a64-ccu.h> +#include <dt-bindings/reset/sun8i-de2.h> / { interrupt-parent = <&gic>;@@ -168,6 +170,19 @@ #size-cells = <1>; ranges; + display_clocks: clock at 1000000 { + compatible = "allwinner,sun50i-a64-de2-clk", + "allwinner,sun50i-h5-de2-clk";The A64 was released before the H5, so that should be the other way around.quoted
+ reg = <0x01000000 0x100000>; + clocks = <&ccu CLK_DE>, + <&ccu CLK_BUS_DE>; + clock-names = "mod", + "bus"; + resets = <&ccu RST_BUS_DE>; + #clock-cells = <1>; + #reset-cells = <1>; + }; +So it turns out we don't need the SRAM to access the CCU driver?As now U-Boot claims SRAM, people may forget thus :-(
This is definitely not ok. We should have that described in the DT as well. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180502/28dd3bda/attachment-0001.sig>