On Mon, 2018-05-14 at 11:35 +0100, Marc Zyngier wrote:
On 14/05/18 11:22, Erin Lo wrote:
quoted
From: Ben Ho <redacted>
Add basic chip support for Mediatek 8183
Signed-off-by: Ben Ho <redacted>
Signed-off-by: Erin Lo <redacted>
---
arch/arm64/boot/dts/mediatek/Makefile | 1 +
arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 31 +++++
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 178 ++++++++++++++++++++++++++++
3 files changed, 210 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi
[...]
quoted
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
new file mode 100644
index 0000000..8564a26
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
[...]
quoted
+ gic: interrupt-controller at 0c000000 {
+ compatible = "arm,gic-v3";
+ #interrupt-cells = <3>;
+ interrupt-parent = <&gic>;
+ interrupt-controller;
+ reg = <0 0x0c000000 0 0x40000>, // CID
+ <0 0x0c100000 0 0x200000>; // CIR
You're missing the GICV and GICH regions that are present on both A53
and A73 at an offset from PERIPHBASE.
quoted
+ interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
+ };
Thanks,
M.
I will fill out the GICV and GICH in next round.
Thanks.
Regards,
Erin