Thread (12 messages) 12 messages, 3 authors, 2018-05-08

[PATCH 3/3] dma-debug: unexport dma_debug_resize_entries and debug_dma_dump_mappings

From: robin.murphy@arm.com (Robin Murphy)
Date: 2018-05-08 10:05:25
Also in: linux-alpha, linux-arch, linux-iommu, linux-sh, lkml, sparclinux

On 24/04/18 15:02, Christoph Hellwig wrote:
Only used by the AMD GART driver, which must be built in.
FWIW debug_dma_dump_mappings() is also called by the Intel VT-d driver, 
but the same reasoning still applies. This does rather beg the question 
of whether it's right to have bits of low-level dma-debug internals 
*only* called by a couple of IOMMU drivers, but that can wait for 
another day.

Reviewed-by: Robin Murphy <robin.murphy@arm.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
  lib/dma-debug.c | 2 --
  1 file changed, 2 deletions(-)
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 075253cb613b..6a1ebaa83623 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -444,7 +444,6 @@ void debug_dma_dump_mappings(struct device *dev)
  		spin_unlock_irqrestore(&bucket->lock, flags);
  	}
  }
-EXPORT_SYMBOL(debug_dma_dump_mappings);
  
  /*
   * For each mapping (initial cacheline in the case of
@@ -753,7 +752,6 @@ int dma_debug_resize_entries(u32 num_entries)
  
  	return ret;
  }
-EXPORT_SYMBOL(dma_debug_resize_entries);
  
  /*
   * DMA-API debugging init code
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help