[PATCH] pinctrl: sunxi: always look for apb block
From: andre.przywara@arm.com (Andre Przywara)
Date: 2018-03-01 11:37:01
Also in:
linux-gpio
Subsystem:
arm/allwinner sunxi soc support, pin control subsystem, the rest · Maintainers:
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Linus Walleij, Linus Torvalds
The Allwinner pinctrl device tree binding suggests that a clock named "apb" would drive the pin controller IP. However (for legacy reasons) we rely on this clock actually being the first clock defined. Since named clocks can be in any order, let's explicitly check for a clock called "apb" first, then revert to using the first (and only!) clock to keep compatibility with older DTs. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 4b6cb25bc796..897ba13e6a03 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c@@ -1360,10 +1360,21 @@ int sunxi_pinctrl_init_with_variant(struct platform_device *pdev, goto gpiochip_error; } - clk = devm_clk_get(&pdev->dev, NULL); + clk = devm_clk_get(&pdev->dev, "apb"); if (IS_ERR(clk)) { - ret = PTR_ERR(clk); - goto gpiochip_error; + /* + * If no "apb" clock can be found, try the first one, which + * must be the only one defined. + */ + if (PTR_ERR(clk) == -ENOENT && + of_count_phandle_with_args(node, "clocks", + "#clock-cells") == 1) + clk = devm_clk_get(&pdev->dev, NULL); + + if (IS_ERR(clk)) { + ret = PTR_ERR(clk); + goto gpiochip_error; + } } ret = clk_prepare_enable(clk);
--
2.14.1