On 15 March 2018 at 19:54, Stephen Boyd [off-list ref] wrote:

Quoting riku.voipio at linaro.org (2018-03-12 03:49:45)

quoted

From: Riku Voipio <redacted>

Without COMMON_CLK_HI655X Wifi and bluetooth are non-functional on Hikey.
As suggested by Arnd, enable the driver automatically when the parent
driver is selected. With sensible defaults in place, we can leave other
choices for EXPERT.

Cc: John Stultz <redacted>
Cc: Ulf Hansson <redacted>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Daniel Lezcano <redacted>
Suggested-by: Arnd Bergmann <redacted>
Signed-off-by: Riku Voipio <redacted>
---
Previous discussion at https://patchwork.kernel.org/patch/9767143/
---
 drivers/clk/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 98ce9fc6e6c0..448ce83b334d 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig

@@ -55,8 +55,10 @@ config COMMON_CLK_RK808
          by control register.

 config COMMON_CLK_HI655X
-       tristate "Clock driver for Hi655x"
-       depends on MFD_HI655X_PMIC || COMPILE_TEST
+       tristate "Clock driver for Hi655x" if EXPERT

Hmm. This would be the first EXPERT usage in the clk code. I guess
that's ok.

Put it this way - would you comfortable letting a non-expert fiddle this option?

quoted

+       depends on (MFD_HI655X_PMIC || COMPILE_TEST)
+       depends on REGMAP
+       default MFD_HI655X_PMIC