Quoting ilialin at codeaurora.org (2018-03-20 07:04:05)

quoted

From: Stephen Boyd <sboyd@kernel.org>
Quoting Ilia Lin (2018-02-14 05:59:50)

quoted

 static const u8 prim_pll_regs[PLL_OFF_MAX_REGS] = {
        [PLL_OFF_L_VAL] = 0x04,

@@ -399,10 +424,64 @@ struct clk_hw_clks {
        return ret;
 }

+#define CPU_AFINITY_MASK 0xFFF
+#define PWRCL_CPU_REG_MASK 0x3
+#define PERFCL_CPU_REG_MASK 0x103
+
+/* ACD static settings (HMSS HPG 7.2.2) */ #define L2ACDCR_REG
+0x580ULL #define L2ACDTD_REG 0x581ULL #define L2ACDDVMRC_REG

0x584ULL

quoted

+#define L2ACDSSCR_REG 0x589ULL #define ACDTD_VAL 0x00006A11

#define

quoted

+ACDCR_VAL 0x002C5FFD #define ACDSSCR_VAL 0x00000601 #define
+ACDDVMRC_VAL 0x000E0F0F

Please don't have #defines for random register settings. It just obfuscates
what's going on at the place where the define is used.

So should I just use the values directly?

Yes.