Thread (47 messages) 47 messages, 5 authors, 2018-04-18

[PATCH v5 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi

From: Bjorn Andersson <hidden>
Date: 2018-03-27 17:04:46
Also in: linux-arm-msm, linux-devicetree, lkml

On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote:
+	soc {
+		pinctrl at 1000000 {
+			serial_0_pins: serial0_pinmux {
Please, no underscores in the node name.
+				mux {
Fyi, you can put the pinctrl properties directly into the state node,
omitting the "mux" level.
+					pins = "gpio16", "gpio17";
+					function = "blsp_uart0";
+					bias-disable;
+				};
+			};
+
Apart from this the patch looks good.

Regards,
Bjorn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help