Thread (28 messages) 28 messages, 4 authors, 2018-03-16

[PATCH 3/7] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs

flat view

From: okaya at codeaurora.org <hidden>
Date: 2018-03-14 12:06:35
Also in: linux-arm-msm, linux-rdma, lkml, netdev

On 2018-03-14 00:12, Jason Gunthorpe wrote:
On Tue, Mar 13, 2018 at 11:20:24PM -0400, Sinan Kaya wrote:
quoted
Code includes wmb() followed by writel() in multiple places. writel()
already has a barrier on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing 
the
register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Signed-off-by: Sinan Kaya <redacted>
 drivers/infiniband/hw/qedr/verbs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Sure matches my understanding of writel_relaxed

This is part of a series, should we take just this patch through the
rdma tree? If not:

Acked-by: Jason Gunthorpe <redacted>
Feel free to take pieces.

Thanks,
Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help