Thread (33 messages) 33 messages, 3 authors, 2018-03-04
STALE3011d

[PATCH] nvmem: uniphier-efuse: fix ptr_ret.cocci warnings

From: kbuild test robot <hidden>
Date: 2018-03-04 00:47:47
Also in: linux-amlogic, linux-mediatek, linux-rockchip, lkml

From: Fengguang Wu <redacted>

drivers/nvmem/uniphier-efuse.c:64:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: d562efb89f70 ("nvmem: uniphier-efuse: Convert to use devm_nvmem_register()")
CC: Andrey Smirnov <redacted>
Signed-off-by: Fengguang Wu <redacted>
---

 uniphier-efuse.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/nvmem/uniphier-efuse.c
+++ b/drivers/nvmem/uniphier-efuse.c
@@ -61,10 +61,7 @@ static int uniphier_efuse_probe(struct p
 	econfig.priv = priv;
 	econfig.dev = dev;
 	nvmem = devm_nvmem_register(dev, &econfig);
-	if (IS_ERR(nvmem))
-		return PTR_ERR(nvmem);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(nvmem);
 }
 
 static const struct of_device_id uniphier_efuse_of_match[] = {
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help