Hi Linus,

On Fri, Mar 02, 2018 at 02:21:37PM +0100, Linus Walleij wrote:

On Fri, Mar 2, 2018 at 4:50 AM, Manivannan Sadhasivam
[off-list ref] wrote:

quoted

Add pinctrl driver for Actions Semi S900 SoC. The driver supports
pinctrl, pinmux and pinconf functionalities through a range of registers
common to both gpio driver and pinctrl driver.

Pinmux functionality is available only for the pin groups while the
pinconf functionality is available for both pin groups and individual
pins.

Signed-off-by: Manivannan Sadhasivam <redacted>

Seems like this is pretty much finished.

Let's see if you can collect some ACKs before we apply it.

Andreas is at Embedded World conference. I hope once he is
back, he will have a look at this patchset.

Now just minor things remain.

Random chosen example:

quoted

+static unsigned int lvds_e_drv_pads[] = {
+       LVDS_EEP,
+       LVDS_EEN,
+       LVDS_EDP,
+       LVDS_EDN,
+       LVDS_ECP,
+       LVDS_ECN,
+       LVDS_EBP,
+       LVDS_EBN,
+};
+
+static unsigned int sd0_d3_d0_drv_pads[] = {
+       SD0_D3,
+       SD0_D2,
+       SD0_D1,
+       SD0_D0,
+};

People (e.g. Torvalds) sometimes get upset with files with too many lines
in them. This file has a lot of lines. A lot of pin control drivers try to cut
down the lines with macros, and you do it in some places too,
would you consider to see if you can cut down these tables with
macros?

S900_PADS(LVDS_EEP, LVDS_EEN, LVDS_EDP, LVDS_EDN,
                    LVDS_ECP, LVDS_ECN, LVDS_EBP, LVDS_EBN);
S900_PADS(SD0_D3, SD0_D2, SD0_D1, SD0_D0);

I don't think it would be efficient to use macros here. However, I can
align the pads and func definitions in a single line. This will also
save a considerable amount of space.

Thanks,
Mani

Would be so much more compact.

It's not the biggest problem though.

Yours,
Linus Walleij