Thread (5 messages) 5 messages, 2 authors, 2018-03-05

[PATCH 1/2] ARM: dts: STi: Fix aliases property name for STi boards

From: Patrice CHOTARD <hidden>
Date: 2018-03-05 16:53:58
Also in: linux-devicetree, linux-serial, lkml

Hi Rob

On 03/05/2018 04:28 PM, Rob Herring wrote:
On Mon, Mar 5, 2018 at 9:00 AM,  [off-list ref] wrote:
quoted
From: Patrice Chotard <redacted>

Since dtc v1.4.6-9-gaadd0b65c987, aliases property name must
be lowercase only.
This allows to fix following warnings when compiling dtb
with W=1 option :
I'm so glad to see fixes before the dtc update landed in the kernel tree!
;-)
quoted
arch/arm/boot/dts/stih418-b2199.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih407-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2260.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
arch/arm/boot/dts/stih410-b2120.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Signed-off-by: Patrice Chotard <redacted>
---
  arch/arm/boot/dts/stih407-b2120.dts | 4 ++--
  arch/arm/boot/dts/stih410-b2120.dts | 4 ++--
  arch/arm/boot/dts/stih410-b2260.dts | 4 ++--
  arch/arm/boot/dts/stih418-b2199.dts | 4 ++--
  4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
index c8ad905d0309..fa1186af6574 100644
--- a/arch/arm/boot/dts/stih407-b2120.dts
+++ b/arch/arm/boot/dts/stih407-b2120.dts
@@ -14,7 +14,7 @@
         compatible = "st,stih407-b2120", "st,stih407";

         chosen {
-               bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+               bootargs = "console=ttyas0,115200 clk_ignore_unused";
The kernel change for this is an ABI breakage both DT <-> kernel and
kernel <-> userspace.

Really, if you are okay with doing this, you should change it to ttySx IMO.
OK i will use serialN instead
quoted
                 linux,stdout-path = &sbc_serial0;
And since you have this, you don't even need the console praram.
Ok, i will remove stdout-path in an additional patch
quoted
         };
@@ -24,7 +24,7 @@
         };

         aliases {
-               ttyAS0 = &sbc_serial0;
+               ttyas0 = &sbc_serial0;
The correct fix is use "serialN" for aliases.
Ok
I have a check for only known alias names which would give a better
warning, but David thought it was too restrictive.
quoted
                 ethernet0 = &ethernet0;
         };

Thanks

Patrice
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help