Thread (8 messages) 8 messages, 2 authors, 2018-03-07

[PATCH v2 3/3] tty: st-asc: Update tty alias

From: Patrice CHOTARD <hidden>
Date: 2018-03-07 08:02:06
Also in: linux-devicetree, linux-serial, lkml

Hi Rob

On 03/06/2018 02:29 PM, Rob Herring wrote:
quoted hunk ↗ jump to hunk
On Tue, Mar 6, 2018 at 2:07 AM,  [off-list ref] wrote:
quoted
From: Patrice Chotard <redacted>

Since dtc v1.4.6-9-gaadd0b65c987, aliases property name
must include only lowercase and '-'.

After having updated all STi boards serial aliases from "ttyASN"
to "serialN", st-asc driver need to be updated accordingly as tty
aliases id is retrieved using of_alias_get_id(np, ASC_SERIAL_NAME);
Again, changing the tty name breaks userspace. You can't do that.

You need to do something like this:
diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index c763253514e9..5f9f01fac6dd 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -782,7 +782,9 @@ static struct asc_port *asc_of_get_asc_port(struct
platform_device *pdev)
         if (!np)
                 return NULL;

-       id = of_alias_get_id(np, ASC_SERIAL_NAME);
+       id = of_alias_get_id(np, "serial");
+       if (id < 0)
+               id = of_alias_get_id(np, ASC_SERIAL_NAME);

         if (id < 0)
                 id = 0;
I will fix this too

Patrice
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help