Thread (15 messages) 15 messages, 3 authors, 2018-03-28
STALE2989d

[PATCH 1/6] clocksource: timer-ti-dm: Make unexported functions static

From: tony@atomide.com (Tony Lindgren)
Date: 2018-02-27 19:23:54
Also in: linux-omap, linux-pwm

* Ladislav Michl [off-list ref] [180227 19:09]:
On Tue, Feb 27, 2018 at 10:06:41AM -0800, Tony Lindgren wrote:
quoted
* Ladislav Michl [off-list ref] [180223 10:14]:
quoted
As dmtimer no longer exports functions, make those previously
exported static (this requires few functions to be moved around
as their prototypes were deleted).
Looks like this one fails to build with omap1_defconfig:

drivers/clocksource/timer-ti-dm.c:935:14: error:
'omap_dm_timer_get_fclk' undeclared here 
Umm, it compiled fine on top of previous versions, so I didn't bother
to retest. I'm sorry about it.
quoted
Other than that the first three patches seem like nice
clean-up :)
So are you okay with sending those separately as cleanup with above
issue fixed?
Yeah seems like those first three are suitable for applying
on top of the patches in omap-for-v4.17/timer :)
But to be honest, I'm more interested how to do the last two patches
right ;-)
Yeah well if patch 4 can be sent separately as a fix, then
send that separately to Thierry?

Then you're just left with the pending pwm changes that
still need work it seems.

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help