Thread (3 messages) flat view 3 messages, 2 authors, 2018-02-16
DORMANTno replies

[PATCH 1/2] arm64: uaccess: Clean up types for access_ok()

From: catalin.marinas@arm.com (Catalin Marinas)
Date: 2018-02-16 18:28:14

On Fri, Feb 16, 2018 at 05:04:22PM +0000, Robin Murphy wrote:
In converting __range_ok() into a static inline, I inadvertently made
it more type-safe, but without considering the ordering of the relevant
conversions. This leads to quite a lot of Sparse noise about the fact
that we use __chk_user_ptr() after addr has already been converted from
a user pointer to an unsigned long.

Tweak the prototype and locals so the types all make logical sense and
Sparse is happy (although the resulting codegen remains identical). The
only external site this affects is in compat syscalls where the inferred
"user-pointer-ness" of a register value now warrants an explicit cast.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Both applied. Thanks.

-- 
Catalin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help