[PATCH 0/8] R-Car M3-N: Enable EtherAVB device node
From: jacopo@jmondi.org (jacopo mondi)
Date: 2018-02-27 08:28:53
Also in:
linux-devicetree, linux-iommu, linux-renesas-soc, lkml, netdev
Hi Geert, On Mon, Feb 26, 2018 at 07:28:47PM +0100, Geert Uytterhoeven wrote:
Hi Jacopo, On Mon, Feb 26, 2018 at 6:57 PM, Jacopo Mondi [off-list ref] wrote:quoted
as discussed with you Sergei and Geert, in order to enable EtherAVB for R8A77965 we first wanted to make the phy-mode "rgmii-txid" a board specific property for all other SoCs.Thanks for your series!quoted
This series adds the phy-mode property to salvator-common.dtsi and reset the one for R8A77965/R8A7796/R8A77995 to "rgmii".I forgot that r8a7795.dtsi and r8a7796.dtsi are used for the ULCB boards, too. So to avoid regressions, you need to make a similar change to ulcb.dtsi like you made for salvator-common.dtsi. In addition, r8a77995.dtsi is only used for the Draak board. So you have to update r8a7795-draak.dtsi first, too.
Of course! I forgot about ULCB (and had a patch for Draak I lost while rebasing :/ )
quoted
Then, in order to enable EtherAVB for R-Car M3-N, iommu nodes had to be added as they are referenced by the "avb" device node (CC the iommu list for the series for that reason).I don't think we need the iommu properties and nodes at this early stage. Ethernet works fine without them. Simon, do you agree?
I'll wait for Simon reply and then resend, possibly without iommu and ULCB and Draak patches! Thanks j
P.S. scripts/dtc/dtx_diff is a great tool to compare DTBs before and after your
changes. It would have revealed the changes for ULCB and Draak.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds