[PATCH 11/15] gpio: rcar: Add R-Car M3-N compatible string

Hi Jacopo,

On Tue, Feb 20, 2018 at 2:35 PM, jacopo mondi [off-list ref] wrote:

On Wed, Feb 14, 2018 at 03:05:05PM +0100, Geert Uytterhoeven wrote:

quoted

On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi
[off-list ref] wrote:

quoted

Add compatible string for R-Car M3-N (r8a77965) in gpio-rcar.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

quoted

--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c

@@ -360,6 +360,10 @@ static const struct of_device_id gpio_rcar_of_table[] = {
                /* Gen3 GPIO is identical to Gen2. */
                .data = &gpio_rcar_info_gen2,
        }, {
+               .compatible = "renesas,gpio-r8a77965",
+               /* Gen3 GPIO is identical to Gen2. */
+               .data = &gpio_rcar_info_gen2,
+       }, {

This part is not needed, as the driver already matches agains the generic
"renesas,rcar-gen3-gpio".

Just to point out that the compatible string is there for M3-W and H3.
Anyway, if that's not good practice to add per-SoC strings here, I'll
drop this bit.

That's correct. Initially, we added the H3 string first, and the M3-W later.
After that we learned about new future Gen3 members, and we started using
the family-specific one.

Note that we cannot drop the strings for H3 and M3-W from the driver, as
old DTBs do not have the family-specific strings.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds