[PATCH 2/2] perf inject: Emit instruction records on ETM trace discontinuity

-----Original Message-----
From: Arnaldo Carvalho de Melo [mailto:acme at kernel.org]
Sent: 15 February 2018 14:57
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Robert Walker <redacted>; linux-
kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
coresight at lists.linaro.org
Subject: Re: [PATCH 2/2] perf inject: Emit instruction records on ETM

trace

discontinuity

Em Tue, Feb 13, 2018 at 03:22:33PM -0700, Mathieu Poirier escreveu:

quoted

On Wed, Feb 07, 2018 at 01:57:25PM +0000, Robert Walker wrote:

quoted

@@ -946,20 +982,19 @@ static int cs_etm__run_decoder(struct

cs_etm_queue *etmq)

quoted

quoted

 		/* Run trace decoder until buffer consumed or end of trace

*/

quoted

quoted

 		do {
 			processed = 0;
-

this...

quoted

 			err = cs_etm_decoder__process_data_block(
 				etmq->decoder,
 				etmq->offset,
 				&buffer.buf[buffer_used],
 				buffer.len - buffer_used,
 				&processed);
-

and this should have gone in the first patch.

quoted

 			if (err)
 				return err;

 			etmq->offset += processed;
 			buffer_used += processed;

+			/* Process each packet in this chunk */

And probably this too.

With the above changes:

Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Hi Robert,

	Can you please address Mathieu's comments, and if you agree with
them, resubmit?

Thanks!

- Arnaldo

Hi Arnaldo,

I've addressed Mathieu's comments and resubmitted them yesterday
(https://lkml.org/lkml/2018/2/14/185).

Regards

Rob