Thread (30 messages) 30 messages, 5 authors, 2018-02-16

[PATCH 5/8] arm64: dts: renesas: r8a77995: Add LVDS support

From: geert@linux-m68k.org (Geert Uytterhoeven)
Date: 2018-02-15 09:07:20
Also in: linux-devicetree, linux-renesas-soc, lkml

Hi Kieran,

On Thu, Feb 15, 2018 at 9:38 AM, Kieran Bingham [off-list ref] wrote:
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

The r8a77995 D3 platform has 2 LVDS channels connected to the DU.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
I love your patch!
Yet something to improve...
quoted hunk ↗ jump to hunk
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -773,18 +773,70 @@
                                port at 1 {
                                        reg = <1>;
                                        du_out_lvds0: endpoint {
+                                               remote-endpoint = <&du_out_lvds0>;
                                        };
                                };

                                port at 2 {
                                        reg = <2>;
                                        du_out_lvds1: endpoint {
+                                               remote-endpoint = <&du_out_lvds1>;
                                        };
                                };
                        };
                };
        };

+       lvds0: lvds at feb90000 {
+               compatible = "renesas,lvds-r8a77995";
+               reg = <0 0xfeb90000 0 0x20>;
+               clocks = <&cpg CPG_MOD 727>;
+               status = "disabled";
Missing resets, power-domains

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help