[PATCH 1/2] dt-bindings: Documentation for qcom,llcc
From: mark.rutland@arm.com (Mark Rutland)
Date: 2018-02-13 14:33:25
Also in:
linux-arm-msm, lkml
On Thu, Feb 08, 2018 at 04:24:16PM -0800, Channa wrote:
On 2018-02-08 08:52, Matt Sealey wrote:quoted
On 25 January 2018 at 17:55, Channagoud Kadabi [off-list ref] wrote:quoted
Documentation for last level cache controller device tree bindings, client bindings usage examples.[snippety snip]quoted
+- llcc-bank-off: + Usage: required + Value Type: <u32 array> + Definition: Offsets of llcc banks from llcc base address starting from + LLCC bank0. + +- llcc-broadcast-off: + Usage: required + Value Type: <u32> + Definition: Offset of broadcast register from LLCC bank0 address.
quoted
And if you need to describe register offsets... why aren't you able to use the reg property?Reg property did not suit well for my need, so I choose to maintain offsets instead. The registers in the HW block are organized as (offset1) (offset2) (offset3) (offset4) Base(Block0) -- Block1 -- Block 2 -- Block 3 -- Broadcast_Block Each block has identical register mapping. You can think of it as 4 instances of identical HW.
We have similar in other devices (e.g. GICv3 has multiple instances of the same register block). If there's nothing between those blocks, using a reg entry sounds prefectly reasonable. You can list the broadcast block first, then the others, or use reg-names. Thanks, Mark.