Thread (11 messages) 11 messages, 4 authors, 2018-02-15

[PATCH v5 2/3] GHES: add a notify chain for process memory section

From: Borislav Petkov <hidden>
Date: 2018-02-07 10:32:09
Also in: linux-acpi, lkml

On Fri, Jan 26, 2018 at 08:31:24PM +0800, Xie XiuQi wrote:
quoted hunk ↗ jump to hunk
Add a notify chain for process memory section, with
which other modules might do error recovery.

Signed-off-by: Xie XiuQi <redacted>
Tested-by: Wang Xiongfeng <redacted>
Tested-by: Tyler Baicar <redacted>
---
 drivers/acpi/apei/ghes.c | 10 ++++++++++
 include/acpi/ghes.h      |  8 ++++++++
 2 files changed, 18 insertions(+)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index cff671d..1f0ebfb 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -109,6 +109,9 @@ static inline bool is_hest_type_generic_v2(struct ghes *ghes)
 static LIST_HEAD(ghes_hed);
 static DEFINE_MUTEX(ghes_list_mutex);
 
+ATOMIC_NOTIFIER_HEAD(ghes_mem_err_chain);
+EXPORT_SYMBOL(ghes_mem_err_chain);
Definitely not EXPORT_SYMBOL.

And certainly not export the notifier head. Have register and unregister
functions instead.

That is, *if* you can't solve it differently with James. Notifiers
should be avoided if possible.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imend?rffer, Jane Smithard, Graham Norton, HRB 21284 (AG N?rnberg)
-- 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help