Thread (4 messages) flat view 4 messages, 2 authors, 2018-02-02
DORMANTno replies

[PATCH 1/2] i2c-davinci: Delete an error message for a failed memory allocation in davinci_i2c_probe()

From: SF Markus Elfring <hidden>
Date: 2018-02-02 17:34:31
Also in: kernel-janitors, linux-i2c, lkml
Subsystem: i2c subsystem, i2c subsystem host drivers, the rest, ti davinci machine support · Maintainers: Andi Shyti, Linus Torvalds, Bartosz Golaszewski

From: Markus Elfring <redacted>
Date: Fri, 2 Feb 2018 18:00:20 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/i2c/busses/i2c-davinci.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index cb24a3ffdfa2..71a9c29b3981 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -784,10 +784,8 @@ static int davinci_i2c_probe(struct platform_device *pdev)
 
 	dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),
 			GFP_KERNEL);
-	if (!dev) {
-		dev_err(&pdev->dev, "Memory allocation failed\n");
+	if (!dev)
 		return -ENOMEM;
-	}
 
 	init_completion(&dev->cmd_complete);
 #ifdef CONFIG_CPU_FREQ
-- 
2.16.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help