[PATCH 1/9] serial: arc_uart: Fix out-of-bounds access through DT alias
From: geert+renesas@glider.be (Geert Uytterhoeven)
Date: 2018-02-20 09:58:03
Also in:
linux-devicetree, linux-renesas-soc, linux-serial, lkml
Subsystem:
synopsys arc architecture, the rest, tty layer and serial drivers · Maintainers:
Vineet Gupta, Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby
The arc_uart_ports[] array is indexed using a value derived from the
"serialN" alias in DT, which may lead to an out-of-bounds access.
Fix this by adding a range check.
Note that the array size is defined by a Kconfig symbol
(CONFIG_SERIAL_ARC_NR_PORTS), so this can even be triggered using a
legitimate DTB.
Fixes: 10640deb04b7949a ("serial: arc_uart: Fix out-of-bounds access through DT alias")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/arc_uart.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 2599f9ecccfe7769..1cb827a6b836d0dd 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c@@ -593,6 +593,11 @@ static int arc_serial_probe(struct platform_device *pdev) if (dev_id < 0) dev_id = 0; + if (dev_id >= CONFIG_SERIAL_ARC_NR_PORTS) { + dev_err(&pdev->dev, "serial%d out of range\n", dev_id); + return -EINVAL; + } + uart = &arc_uart_ports[dev_id]; port = &uart->port;
--
2.7.4