Thread (13 messages) flat view 13 messages, 3 authors, 2018-02-20

[RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

From: krzk@kernel.org (Krzysztof Kozlowski)
Date: 2018-02-15 12:14:58
Also in: dri-devel, linux-devicetree, linux-samsung-soc, linux-usb, lkml

On Thu, Feb 15, 2018 at 11:39 AM, Andrzej Hajda [off-list ref] wrote:
quoted hunk ↗ jump to hunk
OF graph describes MHL data lanes between MHL and respective USB
connector.

Signed-off-by: Andrzej Hajda <redacted>
---
 .../boot/dts/exynos/exynos5433-tm2-common.dtsi     | 31 +++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
index 7e49fadee412..ef758f7337e9 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
@@ -779,9 +779,22 @@
                clocks = <&pmu_system_controller 0>;
                clock-names = "xtal";

-               port {
-                       mhl_to_hdmi: endpoint {
-                               remote-endpoint = <&hdmi_to_mhl>;
+               ports {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+
+                       port at 0 {
+                               reg = <0>;
+                               mhl_to_hdmi: endpoint {
+                                       remote-endpoint = <&hdmi_to_mhl>;
+                               };
+                       };
+
+                       port at 1 {
+                               reg = <1>;
+                               mhl_to_musb_con: endpoint {
+                                       remote-endpoint = <&musb_con_to_mhl>;
+                               };
                        };
                };
        };
@@ -804,6 +817,18 @@
                                             "usb-b-connector";
                                label = "micro-USB";
                                type = "micro";
+
+                               ports {
+                                       #address-cells = <1>;
+                                       #size-cells = <0>;
+
+                                       port at 3 {
I think you might need here "reg = <3>". Doesn't it produce a warning now?

BR,
Krzysztof
+                                               musb_con_to_mhl: endpoint {
+                                                       remote-endpoint = <&mhl_to_musb_con>;
+                                               };
+                                       };
+                               };
+                       };
                        };
                };

--
2.16.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help