On Wed, Jan 31, 2018 at 12:19:31PM +0000, Russell King - ARM Linux wrote:

On Wed, Jan 31, 2018 at 12:06:29PM +0000, Dave Martin wrote:

quoted

Hi all,

Question:

 1) Should a UART definitely discard the RX FIFO on ->startup()?

Yes; POSIX makes no guarantees about the configuration of the port
while it is closed, and when it is re-opened, it is permitted that
the port is reset back to a set of default parameters rather than
the previous parameter set that was configured.

You also have the CREAD flag which indicates whether we want the
receiver enabled or not, but it is not defined by POSIX whether the
receiver remains enabled when the port is closed.

Linux behaviour has always been to flush the port of received
characters at close and open time (see 8250 driver), meaning that
characters received while the TTY is closed are ignored - just like
what happens on the physical console keyboard, which is also a TTY.
Doing otherwise is likely to confuse applications and potentially
introduce buggy behaviour that would only be detected on UARTs with
differing behaviour to 8250.

Linux follows POSIX General Terminal Interface for its TTY handling.

OK, that all sounds good.

Explicitly reading the RX FIFO until empty on startup seems compatible
with this, and harmless even on hardware that can't show the lockup.

I'll cook up another patch.

Cheers
---Dave