[RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd
From: Peter Chen <hidden>
Date: 2018-01-26 09:06:33
Also in:
linux-mediatek, linux-usb
quoted hunk ↗ jump to hunk
Now that usb_add_hcd parses all generic PHYs anyways the code which skips initialization of a single PHY will go away. Remove the code which sets struct usb_hcd's phy field from the chipidea driver as this field will go away soon. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/usb/chipidea/host.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index19d60ed7e41f..fc324767cb0f 100644--- a/drivers/usb/chipidea/host.c +++ b/drivers/usb/chipidea/host.c@@ -124,9 +124,7 @@ static int host_start(struct ci_hdrc *ci) hcd->power_budget = ci->platdata->power_budget; hcd->tpl_support = ci->platdata->tpl_support; - if (ci->phy) - hcd->phy = ci->phy; - else + if (!ci->phy) hcd->usb_phy = ci->usb_phy;
The reason hcd->phy is initialized by chipidea core is we do not need HCD core to touch PHY, and PHY operation is shared for both device and host mode for chipidea. If I understand correct, your HCD core PHY wrapper patch set will do PHY operation if there is a "phy" node under controller's? If it is correct, you may supply one way to let the HCD core bypass phy operations for some USB controllers, eg dual-role controllers. Thanks. Peter