[PATCH 02/14] mmc: mmci: Don't pretend all variants to have MCI_STARBITERR flag
From: Ulf Hansson <hidden>
Date: 2018-01-15 12:32:19
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-mmc, lkml
On 12 January 2018 at 13:15, [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Patrice Chotard <redacted> This patch prepares for supporting the STM32 variant that has no such bit in the status register. Signed-off-by: Andrea Merello <redacted> Signed-off-by: Patrice Chotard <redacted> --- drivers/mmc/host/mmci.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index 3125dc0..7e56f85 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c@@ -83,6 +83,8 @@ * @qcom_dml: enables qcom specific dma glue for dma transfers. * @reversed_irq_handling: handle data irq before cmd irq. * @mmcimask1: true if variant have a MMCIMASK1 register. + * @start_err: true is the variant has STARTBITERR bit inside MMCISTATUS + * register. */ struct variant_data { unsigned int clkreg;@@ -113,6 +115,7 @@ struct variant_data { bool qcom_dml; bool reversed_irq_handling; bool mmcimask1; + bool start_err;
To be consistent with how we implement support for similar variant variations, I would prefer to have this being a u32. Something along the lines of how the "busy_detect_flag" is being used. Otherwise this looks good to me. [...] Kind regards Uffe