Thread (2 messages) 2 messages, 2 authors, 2018-01-10

[PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board

flat view

From: Chris.Packham@alliedtelesis.co.nz (Chris Packham)
Date: 2018-01-10 20:08:38
Also in: linux-devicetree, linux-edac, lkml

Hi Gregory,

On 10/01/18 21:24, Gregory CLEMENT wrote:
Hi Chris,

  On mar., janv. 09 2018, Chris Packham [off-list ref] wrote:

Could you have add a (even small) message in the commit log?

Also could you improve the title by specify that it applies on
armada-xp, like this:

ARM: dts: armada-xp: enable L2 cache parity and ecc on db-xc3-24g4xg
Will do.
quoted
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
  arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts | 5 +++++
  1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
index 06fce35d7491..00ca489fc788 100644
--- a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
+++ b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
@@ -70,6 +70,11 @@
  	};
  };
  
+&L2 {
+	arm,parity-enable;
+	marvell,ecc-enable;
It is not a problem for me to already applied the device tree change
even if the driver is not merged yet. But I would like to have an
acked-by on this new property by either a device tree maintainer or at
least the EDAC maintainer, of course having both acked-by would be
perfect ! :)
Thanks, I was hoping you would say that. That way I can keep this 
independent of the EDAC driver changes.
Thanks,

Gregory



quoted
+};
+
  &devbus_bootcs {
  	status = "okay";
  
-- 
2.15.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help