[PATCHv3] dt-bindings: Avago APDS990X light sensor

Hi!

quoted

From: Filip Matijevi? <redacted>

This prepares binding for light sensor used in Nokia N9.

"dt-bindings: ..." is the preferred subject prefix.

Ok.

quoted

+++ b/Documentation/devicetree/bindings/misc/avago-apds990x.txt

Put this with other light sensors whether you use IIO or not:

bindings/iio/light/

Makes sense. Patches to convert to IIO are available.

quoted

@@ -0,0 +1,41 @@
+Avago APDS990X driver

Bindings aren't drivers.

Ok.

quoted

+https://docs.broadcom.com/docs/AV02-2867EN
+
+Required properties:
+- compatible: "avago,apds990x"
+- reg: address on the I2C bus
+- interrupts: external interrupt line number
+- vdd-supply: power supply for VDD
+- vled-supply: power supply for LEDA
+- avago,ga: Glass attenuation

We already have "upisemi,glass-coef". Can we align on something
common.

upisemi seems to have different units (1/1000 vs. 1/4096). Do you want
me to do change to avago,glass-coef or ....?

quoted

+- avago,cf1: Clear channel factor 1
+- avago,irf1: IR channel factor 1
+- avago,cf2: Clear channel factor 2
+- avago,irf2: IR channel factor 2

Perhaps 2 properties with 2 cells for factor 1 and 2.

This is obviously easier to keep, but I can change.

quoted

+- avago,df: Device factor

Units/range for all these?

Fixed point, with 4096 == 1.00.

quoted

+- avago,pdrive: IR current, one of APDS_IRLED_CURR_XXXmA values

Don't we have standard current property for LEDs?

We do have "led-max-microamp"; which is not quite what this is. I
guess we can do "led-microamp" if you prefer?

quoted

+- avago,ppcount: Proximity pulse count

Is this standard for prox sensors?

I don't know many proximity sensors. Seems like way to raise sensitivity.

Best regards,
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180108/d1bebcf2/attachment.sig>