[PATCH 1/2] usb: musb: un-break davinci glue layer

On Tue, Dec 19, 2017 at 05:33:14PM +0000, Alejandro Mery wrote:

Hi Bin,

On 19/12/17 17:22, Bin Liu wrote:

quoted

Hi Alejandro,

On Fri, Dec 08, 2017 at 07:23:54PM +0000, Alejandro Mery wrote:

quoted

MUSB's davinci glue was made to depend on BROKEN by Felipe Balbi back in
2013 because of lack of active development. needed changes were actually trivial

Fixes: 787f5627bec8 (usb: musb: make davinci and da8xx glues depend on BROKEN)
Signed-off-by: Alejandro Mery <redacted>

Thanks for the effort to re-enable this driver. But due to lack of
development, other than the phy and fifo mode which you try to fix with
these two patches, the driver still doesn't fit in the current driver
framework, for example,

- the driver depends on mach/ header for CPU and board type;
- clk control is not separated;
- gpio control vbus should use extcon driver;

I'll try to fix these issues but it will take a while. I'm still
struggling to get USB working at all on the DM365 EVM

Thanks for the effort.

quoted

So I feel it is not ready to un-broken it yet, unless others have
different opinion.

But I could take these two patches if not remove BROKEN from Kconfig.

do you want a v2 for that?

That will be great!

Thanks,
-Bin.