On 14/12/17 12:12, Christoffer Dall wrote:

On Mon, Dec 11, 2017 at 09:53:13AM +0000, Marc Zyngier wrote:

quoted

On 07/12/17 17:06, Christoffer Dall wrote:

quoted

So far this is just a copy of the legacy non-VHE switch function, where
we only change the existing calls to has_vhe() in both the original and
new functions.

I'm not sure I correctly parse the above. Do you want to say that you
use has_vhe() to select the right world switch back-end? Or did you mean
to drop some of the has_vhe() calls in the non-VHE case?

That's a leftover from a previous patch version.  How about the
following instead?

  So far this is just a copy of the legacy non-VHE switch function, but we
  will start reworking these functions in separate directions to work on
  VHE and non-VHE in the most optimal way in later patches.

This makes more sense.With that change:

Reviewed-by: Marc Zyngier <redacted>

	M.
-- 
Jazz is not dead. It just smells funny...