Thread (4 messages) flat view 4 messages, 4 authors, 2017-12-20

[PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

From: prabhakar.csengg@gmail.com (Lad, Prabhakar)
Date: 2017-12-20 13:15:41
Also in: linux-media, linux-renesas-soc, linux-samsung-soc

Hi Mauro,

Thanks for the patch.

On Tue, Dec 19, 2017 at 11:18 AM, Mauro Carvalho Chehab
[off-list ref] wrote:
The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
match criteria requires just a device name.

So, it doesn't make sense to enclose those into structs,
as the criteria can go directly into the union.

That makes easier to document it, as we don't need to document
weird senseless structs.

At drivers, this makes even clearer about the match criteria.

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Benoit Parrot <redacted>
Acked-by: Alexandre Belloni <redacted>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <redacted>
---
 drivers/media/platform/am437x/am437x-vpfe.c    |  6 +++---
For above:

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar Lad
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help