Thread (1 message) 1 message, 1 author, 2017-12-05

[PATCH] arm64: dts: allwinner: a64: bananapi-m64: Add LED device node

From: jagan@amarulasolutions.com (Jagan Teki)
Date: 2017-12-05 06:15:47
Also in: linux-devicetree

On Fri, Dec 1, 2017 at 9:57 PM, Chen-Yu Tsai [off-list ref] wrote:
quoted hunk
The Bananapi-M64 has 3 LEDS in red, green, and blue. These are toggled
via GPIO lines, which drive transistors that control current across the
LEDS. The red LED is by default on, via an additional pull-up on the
control line. We consider this means that it is a power indicator.
So we set the "default-on" property for it.

The pingroups the GPIO lines belong to require external regulators be
enabled to be able to drive the GPIO high. These regulators also have
other purposes. However the pin controller does not have bindings for
regulators. Here we just set them to always-on.

Signed-off-by: Chen-Yu Tsai <redacted>
---
 .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts | 36 ++++++++++++++++++++++
 1 file changed, 36 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
index 4a8d3f83a36e..a6975670cd1c 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
@@ -60,6 +60,26 @@
                stdout-path = "serial0:115200n8";
        };

+       leds {
+               compatible = "gpio-leds";
+
+               pwr-led {
+                       label = "bananapi-m64:red:pwr";
+                       gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
+                       default-state = "on";
+               };
+
+               green {
+                       label = "bananapi-m64:green:user";
+                       gpios = <&pio 4 14 GPIO_ACTIVE_HIGH>; /* PE14 */
+               };
+
+               blue {
+                       label = "bananapi-m64:blue:user";
+                       gpios = <&pio 4 15 GPIO_ACTIVE_HIGH>; /* PE15 */
+               };
+       };
+
        wifi_pwrseq: wifi_pwrseq {
                compatible = "mmc-pwrseq-simple";
                reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */
@@ -153,6 +173,17 @@

 #include "axp803.dtsi"

+&reg_aldo1 {
+       /*
+        * This regulator also drives the PE pingroup GPIOs,
+        * which also controls two LEDs.
+        */
+       regulator-always-on;
+       regulator-min-microvolt = <2800000>;
+       regulator-max-microvolt = <2800000>;
why 2.8v?
quoted hunk
+       regulator-name = "afvcc-csi";
+};
+
 &reg_aldo2 {
        regulator-always-on;
        regulator-min-microvolt = <1800000>;
@@ -168,6 +199,11 @@
 };

 &reg_dc1sw {
+       /*
+        * This regulator also indirectly drives the PD pingroup GPIOs,
+        * which also controls the power LED.
+        */
+       regulator-always-on;
This make rgmii phy always on, does this make emac power-drop?



-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help